Bugfix: duplicated word in seedphrase #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
added
the
needs-qa
ibrahimtaveras00
approved these changes
Feb 14, 2020
danjm
reviewed
Feb 17, 2020
|
|
||
| findNextAvailableIndex = () => { | ||
| const { confirmedWords } = this.state; | ||
| for (let i = 0; i < 12; i++) if (!confirmedWords[i].word) return i; |
There was a problem hiding this comment.
Instead of
for (let i = 0; i < 12; i++) if (!confirmedWords[i].word) return i;
return 12;
could do
return confirmedWords.findIndex(obj => !word)
and then use this.findNextAvailableIndex() === -1 on line 218
danjm
reviewed
Feb 17, 2020
| createWordsDictionary = () => { | ||
| const dict = {}; | ||
| this.words.forEach((word, i) => { | ||
| dict[[word, i]] = { currentPosition: undefined }; |
There was a problem hiding this comment.
Its not exactly clear to anyone ready the code that the keys of dict will be strings of the form 'word,i'
The code could be a bit clearer if the keys were explicitly set with strings.
For example:
dict[`${word},${i}`] = { currentPosition: undefined };
It would then be clearer what is happening when the key is split on line 280
There was a problem hiding this comment.
I can change it if it's not clear
danjm
approved these changes
Feb 17, 2020
|
@ibrahimtaveras00 can you do other QA pass? I've changed the code, just to be sure. I'm pushing the hardcoded seed phrase for you to test it. |
This reverts commit 54acd16.
ibrahimtaveras00
approved these changes
Feb 18, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* progress * cleaner code * fix check * works * almost there * fix some bugs * cleaner * select empty box * done * undo custom changes * Revert "undo custom changes" This reverts commit 774113e. * Revert "Revert "undo custom changes"" This reverts commit 468ae85. * fix bug * snaps * Revert "undo custom changes" This reverts commit 774113e. * Revert "Revert "undo custom changes"" This reverts commit 54acd16. * review comments * seedPhraseReady * Revert "Revert "undo custom changes"" This reverts commit 54acd16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue with duplicated words on seedphrase
Checklist
Issue
Fixes #1233
Fixes #1020